Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indices filter in blobs_sidecar http endpoint #5118

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Fix indices filter in blobs_sidecar http endpoint #5118

merged 4 commits into from
Jan 23, 2024

Conversation

pawanjay176
Copy link
Member

@pawanjay176 pawanjay176 commented Jan 23, 2024 •
edited
Loading

Issue Addressed

Resolves #5107

Proposed Changes

Use a multi_key_query for the beacon/blob_sidecars/{block_id} endpoint's indices filter. This fixes the deserialization of the indices array.

Tried the endpoint on goerli with the following parameters and everything parsed correctly with the expected result

curl -H 'Accept: application/json' 'http://localhost:5052/eth/v1/beacon/blob_sidecars/7460196' | jq
curl -H 'Accept: application/json' 'http://localhost:5052/eth/v1/beacon/blob_sidecars/7460196?indices=0,1' | jq
curl -H 'Accept: application/json' 'http://localhost:5052/eth/v1/beacon/blob_sidecars/7460196?indices=0' | jq
curl -H 'Accept: application/json' 'http://localhost:5052/eth/v1/beacon/blob_sidecars/7460196?indices=1,0' | jq
curl -H 'Accept: application/json' 'http://localhost:5052/eth/v1/beacon/blob_sidecars/7460196?indices=1,0,3' | jq

@pawanjay176 pawanjay176 added the ready-for-review The code is ready for review label Jan 23, 2024
realbigsean
realbigsean approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@realbigsean realbigsean added bug Something isn't working deneb v4.6.0 ETA Q1 2024 labels Jan 23, 2024
michaelsproul
michaelsproul approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix! Let's merge

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 23, 2024
@michaelsproul michaelsproul merged commit b55b58b into sigp:unstable Jan 23, 2024
28 checks passed
@pawanjay176 pawanjay176 mentioned this pull request Jan 24, 2024
Closed
danielrachi1 pushed a commit to danielrachi1/lighthouse that referenced this pull request Feb 14, 2024
@pawanjay176 @realbigsean @danielrachi1
Fix indices filter in blobs_sidecar http endpoint (sigp#5118)
46faffb 
* add get blobs unit test

* Use a multi_key_query for blob_sidecar indices

* Fix test

* Remove env_logger

---------

Co-authored-by: realbigsean <seananderson33@GMAIL.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realbigsean realbigsean realbigsean approved these changes

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
bug Something isn't working deneb ready-for-merge This PR is ready to merge. v4.6.0 ETA Q1 2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pawanjay176 @michaelsproul @realbigsean